Implement option to show passwords by default

This commit is contained in:
Brian Pellin
2010-02-26 23:57:03 -06:00
parent 6d0be1c9c7
commit fa97eb8eb2
4 changed files with 21 additions and 4 deletions

View File

@@ -27,6 +27,8 @@
<string name="db_key">db</string>
<string name="rounds_key">rounds</string>
<string name="keyfile_key">keyfile</string>
<string name="maskpass_key">maskpass</string>
<bool name="maskpass_default">true</bool>
<bool name="keyfile_default">true</bool>
<string name="clipboard_timeout_default">300000</string>

View File

@@ -34,7 +34,7 @@
<string name="building_search_idx">Building search index...</string>
<string name="cancel">Cancel</string>
<string name="ClearClipboard">Clipboard cleared.</string>
<string name="clipboard_timeout">Clipboard Timeout</string>
<string name="clipboard_timeout">Clipboard timeout</string>
<string name="clipboard_timeout_summary">Time before clearing clipboard after copying username or password</string>
<string name="copy_username">Copy username to clipboard</string>
<string name="copy_password">Copy password to clipboard</string>
@@ -86,6 +86,8 @@
<string name="InvalidPassword">Invalid password or key file.</string>
<string name="loading_database">Loading database...</string>
<string name="MaskedPassword">*****</string>
<string name="maskpass_title">Mask password</string>
<string name="maskpass_summary">Hide passwords by default</string>
<string name="menu_about">About</string>
<string name="menu_change_key">Change Master Key</string>
<string name="menu_copy_pass">Copy Password</string>

View File

@@ -52,5 +52,10 @@
android:entryValues="@array/clipboard_timeout_values"
android:dialogTitle="@string/clipboard_timeout"
android:defaultValue="@string/clipboard_timeout_default"/>
<CheckBoxPreference
android:key="@string/maskpass_key"
android:title="@string/maskpass_title"
android:summary="@string/maskpass_summary"
android:defaultValue="@bool/maskpass_default"/>
</PreferenceScreen>
</PreferenceScreen>

View File

@@ -85,7 +85,7 @@ public class EntryActivity extends LockCloseActivity {
private PwEntry mEntry;
private Timer mTimer = new Timer();
private boolean mShowPassword = false;
private boolean mShowPassword;
private int mPos;
private NotificationManager mNM;
private BroadcastReceiver mIntentReceiver;
@@ -114,6 +114,9 @@ public class EntryActivity extends LockCloseActivity {
// Update last access time.
Calendar cal = Calendar.getInstance();
mEntry.tLastAccess = new PwDate(cal.getTime());
SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(this);
mShowPassword = ! prefs.getBoolean(getString(R.string.maskpass_key), getResources().getBoolean(R.bool.maskpass_default));
fillData();
View scroll = findViewById(R.id.entry_scroll);
@@ -211,6 +214,7 @@ public class EntryActivity extends LockCloseActivity {
populateText(R.id.entry_expires, df.format(mEntry.tExpire.getJDate()));
}
populateText(R.id.entry_comment, mEntry.additional);
}
private void populateText(int viewId, int resId) {
@@ -242,8 +246,12 @@ public class EntryActivity extends LockCloseActivity {
menu.add(0, MENU_DONATE, 0, R.string.menu_donate);
menu.findItem(MENU_DONATE).setIcon(android.R.drawable.ic_menu_share);
menu.add(0, MENU_PASS, 0, R.string.show_password);
if ( mShowPassword ) {
menu.add(0, MENU_PASS, 0, R.string.menu_hide_password);
} else {
menu.add(0, MENU_PASS, 0, R.string.show_password);
}
menu.findItem(MENU_PASS).setIcon(android.R.drawable.ic_menu_view);
menu.add(0, MENU_GOTO_URL, 0, R.string.menu_url);
menu.findItem(MENU_GOTO_URL).setIcon(android.R.drawable.ic_menu_upload);