mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2025-12-04 15:39:34 +01:00
5acfcc6a1f
Fixes #11998 Avoids UI lockups by removing several unnecessary mutex blocks and avoiding redundant key detection calls. Detect Yubikeys dynamically when challenging: Prevents issue where correct key cannot be found if the internal state was reset prior to saving This can occur if a user has multiple tabs open and multiple keys connected. Then switches to a locked tab without their DB key inserted which resets detection state. Side Benefit - ensures proper cascade between USB and PC/SC interfaces so users can switch between the two modes seamlessly.
107 lines
2.6 KiB
C++
107 lines
2.6 KiB
C++
/*
|
|
* Copyright (C) 2014 Kyle Manna <kyle@kylemanna.com>
|
|
* Copyright (C) 2017-2021 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef KEEPASSX_YUBIKEY_H
|
|
#define KEEPASSX_YUBIKEY_H
|
|
|
|
#include <QHash>
|
|
#include <QMultiMap>
|
|
#include <QMutex>
|
|
#include <QObject>
|
|
#include <QTimer>
|
|
|
|
#include <botan/secmem.h>
|
|
|
|
typedef QPair<unsigned int, int> YubiKeySlot;
|
|
Q_DECLARE_METATYPE(YubiKeySlot);
|
|
|
|
/**
|
|
* Singleton class to manage the interface to hardware key(s)
|
|
*/
|
|
class YubiKey : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
using KeyMap = QMap<YubiKeySlot, QString>;
|
|
|
|
enum class ChallengeResult : int
|
|
{
|
|
YCR_ERROR = 0,
|
|
YCR_SUCCESS = 1,
|
|
YCR_WOULDBLOCK = 2,
|
|
YCR_KEYNOTFOUND = 3,
|
|
};
|
|
|
|
static YubiKey* instance();
|
|
bool isInitialized();
|
|
|
|
bool findValidKeys();
|
|
void findValidKeysAsync();
|
|
|
|
KeyMap foundKeys();
|
|
int connectedKeys();
|
|
|
|
ChallengeResult challenge(YubiKeySlot slot, const QByteArray& challenge, Botan::secure_vector<char>& response);
|
|
bool testChallenge(YubiKeySlot slot, bool* wouldBlock = nullptr);
|
|
|
|
QString errorMessage();
|
|
|
|
signals:
|
|
/**
|
|
* Emitted when a detection process completes. Use the `detectedSlots`
|
|
* accessor function to get information on the available slots.
|
|
*
|
|
* @param found - true if a key was found
|
|
*/
|
|
void detectComplete(bool found);
|
|
|
|
/**
|
|
* Emitted when user needs to interact with the hardware key to continue
|
|
*/
|
|
void userInteractionRequest();
|
|
|
|
/**
|
|
* Emitted before/after a challenge-response is performed
|
|
*/
|
|
void challengeStarted();
|
|
void challengeCompleted();
|
|
|
|
private:
|
|
explicit YubiKey();
|
|
|
|
static YubiKey* m_instance;
|
|
|
|
QTimer m_interactionTimer;
|
|
bool m_initialized = false;
|
|
bool m_findingKeys = false;
|
|
QString m_error;
|
|
|
|
// Prevents multiple simultaneous operations on hardware keys
|
|
static QMutex s_interfaceMutex;
|
|
|
|
KeyMap m_usbKeys;
|
|
KeyMap m_pcscKeys;
|
|
|
|
int m_connectedKeys = 0;
|
|
|
|
Q_DISABLE_COPY(YubiKey)
|
|
};
|
|
|
|
#endif // KEEPASSX_YUBIKEY_H
|