mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2025-12-04 15:39:34 +01:00
This plugin implements the Secret Storage specification version 0.2. While running KeePassXC, it acts as a Secret Service server, registered on DBus, so clients like seahorse, python-secretstorage, or other implementations can connect and access the exposed database in KeePassXC. Squashed commits: - Initial code - Add SessionAdaptor and fix build - The skeletons for all dbus objects are in place - Implement collection creation and deletion - Emit collectionChanged signal - Implement app-wise settings page - Implement error message on GUI - Implement settings - Fix uuid to dbus path - Implement app level settings - Add freedesktop logo - Implement database settings page - Change database settings to a treeview - Move all settings read/write to one place - Rename SecretServiceOptionsPage to SettingsWidgetFdoSecrets - Fix selected group can not be saved if the user hasn't click on the item - Show selected group per database in app settings - Disable editing of various readonly widgets - Remove unused warning about non exposed database - Fix method signature on dbus adaptors - Fix type derived from DBusObject not recognized as QDBusContext - Resolve a few TODOs around error handling - Remove const when passing DBus exposed objects - Move dismiss to PromptBase - Implement per collection locking/unlocking - Fix const correctness on Item::setSecret - Implement SecretService::getSecrets - Rework the signal connections around collections. - Remove generateId from DBusObject - Per spec, use encoded label as DBus object path for collections - Fix some corner cases around collection name changes - Implement alias - Fix wrong alias dbus path - Implement encryption per spec - Cleanup SessionCipher - Implement searchItems for SecretService - Use Tools::uuidToHex - Implement Item attributes and delete - Implement createItem - Always check if the database is unlocked before perform any operation - Add missing ReadAlias/SetAlias on service - Reorganize and fix OpenSession always returning empty output - Overhaul error handling - Make sure default alias is always present - Remove collection aliases early in doDelete - Handles all content types, fix setProperties not working - Fix sometimes there is an extraneous leading zero when converting from MPI - Fix session encryption negotiation - Do not expose recycle bin - Protect against the methods not called from DBus - Also emit collectionChanged signal when lock state changes - Show notification when entry secret is requested - Add a README file - Actually close session when client disconnects - Gracefully return alternative label when collection is locked - Reorganize, rename secretservice to fdosecrets - Fix issues reported by clazy - Unify UI strings and fix icon - Implement a setting to skip confirmation when deleting entries from DBus - Remove some unused debugging log - Simply ignore errors when DBus context is not available. QtDBus won't set QDBusContext when deliver property get/set, and there is no way to get a QDBusMessage in property getter/setter. - Simplify GcryptMPI using std::unique_ptr and add unit test - Format code in fdosecrets - Move DBusReturnImpl to details namespace - Fix crash when locking a database: don't modify exposedGroup setting in customData when database is deleted - Make sure Collection::searchItems works, whether it's locked or not - Fix FdoSecrets::Collection becomes empty after a database reload - Fix crash when looping while modifying the list
247 lines
6.6 KiB
C++
247 lines
6.6 KiB
C++
/*
|
|
* Copyright (C) 2019 Aetf <aetf@unlimitedcodeworks.xyz>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef KEEPASSXC_FDOSECRETS_DBUSRETURN_H
|
|
#define KEEPASSXC_FDOSECRETS_DBUSRETURN_H
|
|
|
|
#include <QDBusError>
|
|
#include <QDebug>
|
|
#include <QString>
|
|
|
|
#include <type_traits>
|
|
|
|
namespace FdoSecrets
|
|
{
|
|
|
|
namespace details
|
|
{
|
|
class DBusReturnImpl
|
|
{
|
|
public:
|
|
/**
|
|
* Check if this object contains an error
|
|
* @return true if it contains an error, false otherwise.
|
|
*/
|
|
bool isError() const
|
|
{
|
|
return !m_errorName.isEmpty();
|
|
}
|
|
|
|
/**
|
|
* Get the error name
|
|
* @return
|
|
*/
|
|
QString errorName() const
|
|
{
|
|
return m_errorName;
|
|
}
|
|
|
|
void okOrDie() const
|
|
{
|
|
Q_ASSERT(!isError());
|
|
}
|
|
|
|
protected:
|
|
struct WithErrorTag
|
|
{
|
|
};
|
|
|
|
/**
|
|
* Construct from an error
|
|
* @param errorName
|
|
* @param value
|
|
*/
|
|
DBusReturnImpl(QString errorName, WithErrorTag)
|
|
: m_errorName(std::move(errorName))
|
|
{
|
|
}
|
|
|
|
DBusReturnImpl() = default;
|
|
|
|
protected:
|
|
QString m_errorName;
|
|
};
|
|
} // namespace details
|
|
|
|
/**
|
|
* Either a return value or a DBus error
|
|
* @tparam T
|
|
*/
|
|
template <typename T = void> class DBusReturn : public details::DBusReturnImpl
|
|
{
|
|
protected:
|
|
using DBusReturnImpl::DBusReturnImpl;
|
|
|
|
public:
|
|
using value_type = T;
|
|
|
|
DBusReturn() = default;
|
|
|
|
/**
|
|
* Implicitly construct from a value
|
|
* @param value
|
|
*/
|
|
DBusReturn(T&& value) // NOLINT(google-explicit-constructor)
|
|
: m_value(std::move(value))
|
|
{
|
|
}
|
|
|
|
DBusReturn(const T& value) // NOLINT(google-explicit-constructor)
|
|
: m_value(std::move(value))
|
|
{
|
|
}
|
|
|
|
/**
|
|
* Implicitly convert from another error of different value type.
|
|
*
|
|
* @tparam U must not be the same as T
|
|
* @param other
|
|
*/
|
|
template <typename U, typename = typename std::enable_if<!std::is_same<T, U>::value>::type>
|
|
DBusReturn(const DBusReturn<U>& other) // NOLINT(google-explicit-constructor)
|
|
: DBusReturn(other.errorName(), DBusReturnImpl::WithErrorTag{})
|
|
{
|
|
Q_ASSERT(other.isError());
|
|
}
|
|
|
|
/**
|
|
* Construct from error
|
|
* @param errorType
|
|
* @return a DBusReturn object containing the error
|
|
*/
|
|
static DBusReturn Error(QDBusError::ErrorType errorType)
|
|
{
|
|
return DBusReturn{QDBusError::errorString(errorType), DBusReturnImpl::WithErrorTag{}};
|
|
}
|
|
|
|
/**
|
|
* Overloaded version
|
|
* @param errorName
|
|
* @return a DBusReturnImpl object containing the error
|
|
*/
|
|
static DBusReturn Error(QString errorName)
|
|
{
|
|
return DBusReturn{std::move(errorName), DBusReturnImpl::WithErrorTag{}};
|
|
}
|
|
|
|
/**
|
|
* Get a reference to the enclosed value
|
|
* @return
|
|
*/
|
|
const T& value() const&
|
|
{
|
|
okOrDie();
|
|
return m_value;
|
|
}
|
|
|
|
/**
|
|
* Get a rvalue reference to the enclosed value if this object is rvalue
|
|
* @return a rvalue reference to the enclosed value
|
|
*/
|
|
T value() &&
|
|
{
|
|
okOrDie();
|
|
return std::move(m_value);
|
|
}
|
|
|
|
template <typename P> T valueOrHandle(P* p) const&
|
|
{
|
|
if (isError()) {
|
|
if (p->calledFromDBus()) {
|
|
p->sendErrorReply(errorName());
|
|
}
|
|
return {};
|
|
}
|
|
return m_value;
|
|
}
|
|
|
|
template <typename P> T&& valueOrHandle(P* p) &&
|
|
{
|
|
if (isError()) {
|
|
if (p->calledFromDBus()) {
|
|
p->sendErrorReply(errorName());
|
|
}
|
|
}
|
|
return std::move(m_value);
|
|
}
|
|
|
|
private:
|
|
T m_value{};
|
|
};
|
|
|
|
template <> class DBusReturn<void> : public details::DBusReturnImpl
|
|
{
|
|
protected:
|
|
using DBusReturnImpl::DBusReturnImpl;
|
|
|
|
public:
|
|
using value_type = void;
|
|
|
|
DBusReturn() = default;
|
|
|
|
/**
|
|
* Implicitly convert from another error of different value type.
|
|
*
|
|
* @tparam U must not be the same as T
|
|
* @param other
|
|
*/
|
|
template <typename U, typename = typename std::enable_if<!std::is_same<void, U>::value>::type>
|
|
DBusReturn(const DBusReturn<U>& other) // NOLINT(google-explicit-constructor)
|
|
: DBusReturn(other.errorName(), DBusReturnImpl::WithErrorTag{})
|
|
{
|
|
Q_ASSERT(other.isError());
|
|
}
|
|
|
|
/**
|
|
* Construct from error
|
|
* @param errorType
|
|
* @return a DBusReturn object containing the error
|
|
*/
|
|
static DBusReturn Error(QDBusError::ErrorType errorType)
|
|
{
|
|
return DBusReturn{QDBusError::errorString(errorType), DBusReturnImpl::WithErrorTag{}};
|
|
}
|
|
|
|
/**
|
|
* Overloaded version
|
|
* @param errorName
|
|
* @return a DBusReturnImpl object containing the error
|
|
*/
|
|
static DBusReturn Error(QString errorName)
|
|
{
|
|
return DBusReturn{std::move(errorName), DBusReturnImpl::WithErrorTag{}};
|
|
}
|
|
|
|
/**
|
|
* If this is return contains an error, handle it if we were called from DBus
|
|
* @tparam P
|
|
* @param p
|
|
*/
|
|
template <typename P> void handle(P* p) const
|
|
{
|
|
if (isError()) {
|
|
if (p->calledFromDBus()) {
|
|
p->sendErrorReply(errorName());
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
} // namespace FdoSecrets
|
|
|
|
#endif // KEEPASSXC_FDOSECRETS_DBUSRETURN_H
|