From fd57ccc1a7177b023ad44de5e88cfcbfbd8dfa0a Mon Sep 17 00:00:00 2001
From: J-Jamet <jeremy.jamet@kunzisoft.com>
Date: Mon, 2 Nov 2020 17:31:35 +0100
Subject: [PATCH] Copy password from generator #697

---
 CHANGELOG                                     |  1 +
 .../dialogs/GeneratePasswordDialogFragment.kt | 15 ++++--
 .../res/layout/fragment_generate_password.xml | 50 +++++++++++++------
 .../metadata/android/en-US/changelogs/45.txt  |  1 +
 .../metadata/android/fr-FR/changelogs/45.txt  |  1 +
 5 files changed, 48 insertions(+), 20 deletions(-)

diff --git a/CHANGELOG b/CHANGELOG
index 429ee8b7a..08583bd51 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,4 +1,5 @@
 KeePassDX(2.9.1)
+ * Copy password from generator #697
  * Fix Magikeyboard not fully visible #772
  * Fix change font size #770
  * Small fixes #771
diff --git a/app/src/main/java/com/kunzisoft/keepass/activities/dialogs/GeneratePasswordDialogFragment.kt b/app/src/main/java/com/kunzisoft/keepass/activities/dialogs/GeneratePasswordDialogFragment.kt
index 38799873b..ccb47d8f3 100644
--- a/app/src/main/java/com/kunzisoft/keepass/activities/dialogs/GeneratePasswordDialogFragment.kt
+++ b/app/src/main/java/com/kunzisoft/keepass/activities/dialogs/GeneratePasswordDialogFragment.kt
@@ -26,13 +26,11 @@ import com.google.android.material.textfield.TextInputLayout
 import androidx.fragment.app.DialogFragment
 import androidx.appcompat.app.AlertDialog
 import android.view.View
-import android.widget.Button
-import android.widget.CompoundButton
-import android.widget.EditText
-import android.widget.SeekBar
+import android.widget.*
 import com.kunzisoft.keepass.R
 import com.kunzisoft.keepass.password.PasswordGenerator
 import com.kunzisoft.keepass.settings.PreferencesUtil
+import com.kunzisoft.keepass.timeout.ClipboardHelper
 import com.kunzisoft.keepass.view.applyFontVisibility
 
 class GeneratePasswordDialogFragment : DialogFragment() {
@@ -78,6 +76,15 @@ class GeneratePasswordDialogFragment : DialogFragment() {
             passwordInputLayoutView = root?.findViewById(R.id.password_input_layout)
             passwordView = root?.findViewById(R.id.password)
             passwordView?.applyFontVisibility()
+            val passwordCopyView: ImageView? = root?.findViewById(R.id.password_copy_button)
+            passwordCopyView?.visibility = if(PreferencesUtil.allowCopyPasswordAndProtectedFields(activity))
+                View.VISIBLE else View.GONE
+            val clipboardHelper = ClipboardHelper(activity)
+            passwordCopyView?.setOnClickListener {
+                clipboardHelper.timeoutCopyToClipboard(passwordView!!.text.toString(),
+                        getString(R.string.copy_field,
+                                getString(R.string.entry_password)))
+            }
 
             lengthTextView = root?.findViewById(R.id.length)
 
diff --git a/app/src/main/res/layout/fragment_generate_password.xml b/app/src/main/res/layout/fragment_generate_password.xml
index 71916a54a..b506eea0c 100644
--- a/app/src/main/res/layout/fragment_generate_password.xml
+++ b/app/src/main/res/layout/fragment_generate_password.xml
@@ -33,27 +33,45 @@
     android:layout_height="wrap_content"
     android:orientation="vertical">
 
-        <com.google.android.material.textfield.TextInputLayout
-            android:id="@+id/password_input_layout"
+        <androidx.constraintlayout.widget.ConstraintLayout
             android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            app:passwordToggleEnabled="true"
-            app:passwordToggleTint="?attr/colorAccent"
-            android:importantForAccessibility="no"
-            android:importantForAutofill="no">
+            android:layout_height="wrap_content">
 
-            <com.google.android.material.textfield.TextInputEditText
-                android:id="@+id/password"
-                android:layout_width="match_parent"
+            <com.google.android.material.textfield.TextInputLayout
+                android:id="@+id/password_input_layout"
+                android:layout_width="0dp"
                 android:layout_height="wrap_content"
+                app:layout_constraintTop_toTopOf="parent"
+                app:layout_constraintStart_toStartOf="parent"
+                app:layout_constraintEnd_toStartOf="@+id/password_copy_button"
                 android:importantForAccessibility="no"
                 android:importantForAutofill="no"
-                android:ems="10"
-                android:maxLines="3"
-                android:hint="@string/hint_generated_password"
-                android:inputType="textPassword|textMultiLine"
-                tools:ignore="TextFields" />
-        </com.google.android.material.textfield.TextInputLayout>
+                app:passwordToggleEnabled="true"
+                app:passwordToggleTint="?attr/colorAccent">
+
+                <com.google.android.material.textfield.TextInputEditText
+                    android:id="@+id/password"
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:ems="10"
+                    android:hint="@string/hint_generated_password"
+                    android:importantForAccessibility="no"
+                    android:importantForAutofill="no"
+                    android:inputType="textPassword|textMultiLine"
+                    android:maxLines="3"
+                    tools:ignore="TextFields" />
+            </com.google.android.material.textfield.TextInputLayout>
+
+            <androidx.appcompat.widget.AppCompatImageButton
+                android:id="@+id/password_copy_button"
+                style="@style/KeepassDXStyle.ImageButton.Simple"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                app:layout_constraintBottom_toBottomOf="parent"
+                app:layout_constraintEnd_toEndOf="parent"
+                android:contentDescription="@string/menu_copy"
+                android:src="@drawable/ic_content_copy_white_24dp" />
+        </androidx.constraintlayout.widget.ConstraintLayout>
 
         <androidx.appcompat.widget.AppCompatButton
             android:id="@+id/generate_password_button"
diff --git a/fastlane/metadata/android/en-US/changelogs/45.txt b/fastlane/metadata/android/en-US/changelogs/45.txt
index 9a5035232..c37b5486e 100644
--- a/fastlane/metadata/android/en-US/changelogs/45.txt
+++ b/fastlane/metadata/android/en-US/changelogs/45.txt
@@ -1,3 +1,4 @@
+ * Copy password from generator #697
  * Fix Magikeyboard not fully visible #772
  * Fix change font size #770
  * Small fixes #771
\ No newline at end of file
diff --git a/fastlane/metadata/android/fr-FR/changelogs/45.txt b/fastlane/metadata/android/fr-FR/changelogs/45.txt
index 5758953e7..f86c80718 100644
--- a/fastlane/metadata/android/fr-FR/changelogs/45.txt
+++ b/fastlane/metadata/android/fr-FR/changelogs/45.txt
@@ -1,3 +1,4 @@
+ * Copie du mot de passe depuis le générateur #697
  * Correction Magiclavier non complètement visible #772
  * Correction du changement de police #770
  * Petites corrections #771