fix:

Database is 0 Byte if Yubikey save is canceled #1680

app/src/main/java/com/kunzisoft/keepass/database/action/SaveDatabaseRunnable.kt

@@ -51,8 +51,10 @@ open class SaveDatabaseRunnable(
                 // Build temp database file to avoid file corruption if error
                 database.saveData(
                     cacheFile = File(context.cacheDir, databaseCopyUri.hashCode().toString()),
-                    databaseOutputStream = contentResolver
-                        .getUriOutputStream(databaseCopyUri ?: database.fileUri),
+                    databaseOutputStream = {
+                        contentResolver
+                            .getUriOutputStream(databaseCopyUri ?: database.fileUri)
+                    },
                     isNewLocation = databaseCopyUri == null,
                     mainCredential?.toMasterCredential(contentResolver),
                     challengeResponseRetriever)

app/src/main/java/com/kunzisoft/keepass/services/DatabaseTaskNotificationService.kt

@@ -273,13 +273,6 @@ open class DatabaseTaskNotificationService : LockNotificationService(), Progress
             val responseChannel = mResponseChallengeChannel
             if (responseChannel == null || responseChannel.isEmpty) {
                 if (response.isEmpty()) {
-                    Toast.makeText(
-                        this@DatabaseTaskNotificationService,
-                        getString(
-                            R.string.error_action_empty_response_from_challenge),
-                            Toast.LENGTH_LONG
-                        ).show()
-                    mResponseChallengeChannel?.send(response)
                     cancelChallengeResponse(R.string.error_no_response_from_challenge)
                 } else {
                     mResponseChallengeChannel?.send(response)

app/src/main/res/values/strings.xml

@@ -204,7 +204,6 @@
     <string name="error_challenge_already_requested">"Challenge already requested"</string>
     <string name="error_response_already_provided">Response already provided.</string>
     <string name="error_no_response_from_challenge">Unable to get the response from the challenge.</string>
-    <string name="error_action_empty_response_from_challenge">WARNING : Action performed with an empty challenge response.</string>
     <string name="error_cancel_by_user">Cancelled by user.</string>
     <string name="error_driver_required">Driver for %1$s is required.</string>
     <string name="error_unable_merge_database_kdb">Unable to merge from a database V1.</string>